[jdk20] RFR: 8298296: gc/TestFullGCCount.java fails with "System.gc collections miscounted."

Kim Barrett kbarrett at openjdk.org
Wed Dec 14 13:38:48 UTC 2022


On Tue, 13 Dec 2022 13:40:46 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Please review this change to the gc/TestFullGCCount.java test to account for
>> the changes in JDK-8297247.  The test was not updated by that change to
>> account for the new separation by G1 of STW full gc counts from concurrent
>> cycle counts in the GarbageCollectorMXBean.
>> 
>> To address this, the test has been changed to not be run if using G1 and
>> -XX:+ExplicitGCInvokesConcurrent.
>> 
>> Testing:
>> Verified the unmodified test fails when using G1 and +ExplicitGCInvokesConcurrent.
>> After updating the test, ran it with G1 selected and both with and without
>> ExplicitGCInvokesConcurrent.  With now suppresses the test, without runs it
>> successfully.
>
> Marked as reviewed by tschatzl (Reviewer).

Thanks for reviews @tschatzl and @albertnetymk .

-------------

PR: https://git.openjdk.org/jdk20/pull/16


More information about the hotspot-gc-dev mailing list