RFR: 8271195: Use largest available large page size smaller than LargePageSizeInBytes when available [v2]

Swati Sharma duke at openjdk.java.net
Fri Feb 4 11:39:11 UTC 2022


On Thu, 3 Feb 2022 16:48:54 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Swati Sharma has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8271195: Review comments resolved.
>
> src/hotspot/os/linux/os_linux.cpp line 4038:
> 
>> 4036:   if (!large_committed) {
>> 4037:     // Failed to commit large pages, so we need to unmap the whole reservation.
>> 4038:     ::munmap(aligned_start, bytes);
> 
> I don't understand why this change is related to this ticket/PR, or needed at all.

As mentioned above in case of large page commit failure we were partially un reserving the memory which left holes in the virtual address space , we thought of fixing this along with this patch if you suggest we can fix it under another bug id.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7326



More information about the hotspot-gc-dev mailing list