RFR: 8281379: Assign package declarations to all jtreg test cases under gc

Kim Barrett kbarrett at openjdk.java.net
Tue Feb 8 13:07:10 UTC 2022


On Mon, 7 Feb 2022 15:52:35 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

> Assign package declarations to all jtreg test cases under directory "gc". At the moment a few test cases are using no explicit package which makes it hard editing the testcase in an IDE. 
> 
> hotspot_gc passed.

Looks good.  Just a minor formatting suggestion.

test/hotspot/jtreg/gc/g1/numa/TestG1NUMATouchRegions.java line 36:

> 34:  * @build sun.hotspot.WhiteBox
> 35:  * @run driver jdk.test.lib.helpers.ClassFileInstaller sun.hotspot.WhiteBox
> 36:  * @run main/othervm -XX:+UseG1GC -Xbootclasspath/a:. -XX:+UseNUMA -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI gc.g1.numa.TestG1NUMATouchRegions

Since you are touching this overlong line anyway (and making it even longer), could you add a line break or two in there?

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7370



More information about the hotspot-gc-dev mailing list