RFR: 8281637: Remove unused VerifyOption_G1UseNextMarking

[Thomas Schatzl]

On Fri, 11 Feb 2022 11:25:56 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

> Please review this change to remove an unused verification option.
> 
> **Summary**
> In G1 there have been three different `VerifyOption` that can be passed to verification to signal how to determine liveness. One of these options, `VerifyOption_G1UseNextMarking`,  has been unused for quite some time and this change removes it. When removing it the `G1CollectedHeap::is_obj_ill(...)` functions are more or less unused, so I removed those as well and inlined the checks in the only place where it is really used `G1CMIsAliveClosure::do_object_b(...)`
> 
> **Testing**
> 
> - [x] Mach5
> - [x] Local verification testing

Lgtm. Suggested two fixes for typos.

src/hotspot/share/gc/g1/g1ConcurrentMark.inline.hpp line 46:

> 44:   HeapRegion* hr = _g1h->heap_region_containing(cast_from_oop<HeapWord*>(obj));
> 45: 
> 46:   // All objects allocated since the start of marking is considered live.

Suggestion:

  // All objects allocated since the start of marking are considered live.

src/hotspot/share/gc/g1/g1ConcurrentMark.inline.hpp line 51:

> 49:   }
> 50: 
> 51:   // All object in closed archive regions are live.

Suggestion:

  // All objects in closed archive regions are live.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7440