Integrated: 8281748: runtime/logging/RedefineClasses.java failed "assert(addr != __null) failed: invariant"
Stefan Johansson
sjohanss at openjdk.java.net
Tue Feb 15 16:26:07 UTC 2022
On Tue, 15 Feb 2022 11:45:00 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
> Please review this fix for [JDK-8281748](https://bugs.openjdk.java.net/browse/JDK-8281748).
>
> **Summary**
> In a recent [cleanup](https://bugs.openjdk.java.net/browse/JDK-8281637) a NULL-check in `G1CMIsAliveClosure::do_object_b(oop obj)` was forgotten. This was not caught by the initial testing because the only time the check is needed is when a referent is cleared **during** reference discovery, which is quite hard to trigger.
>
> The fix is fairly simple, but returning `true` when a `NULL` is passed in feels a bit counter-intuitive. This behavior is the same as prior to the cleanup causing the error and reading the code this will lead to not discovering references where the referent is `NULL`.
>
> **Testing**
>
> - [ ] Re-running mach5 tier1-5
This pull request has now been integrated.
Changeset: 2fe0bf66
Author: Stefan Johansson <sjohanss at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/2fe0bf66b7cbbae3dc65249be4b04f4075a98efa
Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
8281748: runtime/logging/RedefineClasses.java failed "assert(addr != __null) failed: invariant"
Reviewed-by: ayang, kbarrett
-------------
PR: https://git.openjdk.java.net/jdk/pull/7476
More information about the hotspot-gc-dev
mailing list