RFR: 8271195: Use largest available large page size smaller than LargePageSizeInBytes when available [v6]
Stefan Johansson
sjohanss at openjdk.java.net
Mon Feb 21 12:11:03 UTC 2022
On Mon, 21 Feb 2022 11:33:24 GMT, Swati Sharma <duke at openjdk.java.net> wrote:
>> test/hotspot/jtreg/runtime/os/TestExplicitPageAllocation.java line 188:
>>
>>> 186:
>>> 187: for (int i = index;i >= vmPageSizeIndex;i--) {
>>> 188: if(pageSizes[i]) {
>>
>> An alternative to this would be to have something like `ArrayList<PageSizeConfig>` to which we only add the configured page sizes. And `PageSizeConfig` would hold both the page size and the number of pages configured for this size. I think that would be slightly easier to follow.
>
> Page Count array size increased to 64 this will fix the reported issue and should be sufficient to handle all the page sizes for 64 bit platforms.
Yes, I saw the fix and it will work. I still think a solution like the one I proposed would be both more robust and easier to maintain, but I you prefer this approach I won't block it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7326
More information about the hotspot-gc-dev
mailing list