RFR: 8280958: G1/Parallel: Unify marking code structure
Albert Mingkun Yang
ayang at openjdk.java.net
Mon Feb 21 16:25:51 UTC 2022
On Mon, 21 Feb 2022 15:58:48 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that makes G1 and Parallel Full GC marking code structure a bit more similar both terms of structure as well as naming?
>
> This allows easier comparison and unless we are going to really merge them easier to do changes. They are still a bit different for several reasons:
> * G1 Full GC can disable class unloading while Parallel Full GC always unloads classes
> * different code structure in calls: Parallel GC drains the task queues after every kind of root, G1 only does at the end of all roots
> * root processing between the two collectors is very different
>
> All these are potential follow-ups.
>
> Thanks,
> Thomas
I'd prefer `_stack` suffix over `_tasks`, but ofc this is very subjective.
-------------
Marked as reviewed by ayang (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7561
More information about the hotspot-gc-dev
mailing list