RFR: 8280958: G1/Parallel: Unify marking code structure

[Kim Barrett]

On Mon, 21 Feb 2022 15:58:48 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this change that makes G1 and Parallel Full GC marking code structure a bit more similar both terms of structure as well as naming?
> 
> This allows easier comparison and unless we are going to really merge them easier to do changes. They are still a bit different for several reasons:
>   * G1 Full GC can disable class unloading while Parallel Full GC always unloads classes
>   * different code structure in calls: Parallel GC drains the task queues after every kind of root, G1 only does at the end of all roots
>   * root processing between the two collectors is very different
> 
> All these are potential follow-ups.
> 
> Thanks,
>   Thomas

Looks good.  Just a couple whitespace nits.

src/hotspot/share/gc/g1/g1FullGCMarker.inline.hpp line 187:

> 185:     ObjArrayTask task;
> 186:     if (publish_or_pop_objarray_tasks(task) ||
> 187:       _objarray_stack.pop_local(task)) {

[pre-existing] The indentation is messed up here.

src/hotspot/share/gc/parallel/psCompactionManager.cpp line 146:

> 144:     ObjArrayTask task;
> 145:     if (publish_or_pop_objarray_tasks(task) ||
> 146:       _objarray_stack.pop_local(task)) {

Indentation is messed up here.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7561