RFR: 8282307: Parallel: Incorrect discovery mode in PCReferenceProcessor
Thomas Schatzl
tschatzl at openjdk.java.net
Wed Feb 23 16:06:53 UTC 2022
On Wed, 23 Feb 2022 14:58:46 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Simple followup of [JDK-8273185](https://bugs.openjdk.java.net/browse/JDK-8273185). This bug should not affect correctness though: treating STW discovery as concurrent discovery.
>
> Test: hotspot_gc
Lgtm apart from the pre-existing indentation problem.
src/hotspot/share/gc/parallel/psParallelCompact.cpp line 856:
> 854: ParallelGCThreads, // mt processing degree
> 855: ParallelGCThreads, // mt discovery degree
> 856: false, // concurrent_discovery
It would be nice to improve the indentation of this code, i.e. the parameters of the `ReferenceProcessor` super class constructor call should be indented.
-------------
Marked as reviewed by tschatzl (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7590
More information about the hotspot-gc-dev
mailing list