RFR: 8278282: G1: Log basic statistics for evacuation failure [v3]

Hamlin Li mli at openjdk.java.net
Tue Jan 4 11:59:22 UTC 2022


On Mon, 3 Jan 2022 20:34:03 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into log-evac-failure-region-num
>>  - Fix test
>>  - Initial commit
>
> src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp line 135:
> 
>> 133:   _gc_par_phases[MergePSS]->create_thread_work_items("LAB Undo Waste", MergePSSLABUndoWasteBytes);
>> 134: 
>> 135:   _gc_par_phases[RestoreRetainedRegions]->create_thread_work_items("Evacuation Failure Regions:", RestoreRetainedRegionsNum);
> 
> Based on the surrounding naming conventions, `RestoreRetainedRegionsNum` should probably be sth like `RestoreRetainedRegionsNumEvacFailRegions` or just the suffix `NumEvacFailRegions`.

Thanks Albert, I see your point.
But seems the surrounding naming convention is not that strict, and there is no uniform convention here. And to me, `RestoreRetainedRegionsNum` is more friendly to read and easily related to `RestoreRetainedRegions`, so I prefer to keep it as `RestoreRetainedRegionsNum`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6860



More information about the hotspot-gc-dev mailing list