RFR: 8279008: G1: Calculate BOT threshold on-the-fly during Object Copy phase [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Thu Jan 20 16:09:28 UTC 2022


On Wed, 19 Jan 2022 07:56:43 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/hotspot/share/gc/g1/g1BlockOffsetTable.inline.hpp
>>   
>>   Co-authored-by: Thomas Schatzl <59967451+tschatzl at users.noreply.github.com>
>
> src/hotspot/share/gc/g1/heapRegion.inline.hpp line 248:
> 
>> 246: 
>> 247:   // strictly greater-than
>> 248:   bool cross_card_boundary = (obj_end > cur_card_boundary);
> 
> Any reason for keeping this as a separate statement? Otherwise I would just do the comparison directly in the if-statement.

Just wanna highlight it's "strictly greater-than" and give it a meaningful name to match the method name, "XXX_if_crossing_boundary".

-------------

PR: https://git.openjdk.java.net/jdk/pull/6916



More information about the hotspot-gc-dev mailing list