RFR: 8280396: G1: Full gc mark stack draining should prefer to make work available to other threads [v4]
Thomas Schatzl
tschatzl at openjdk.java.net
Mon Jan 24 16:53:51 UTC 2022
> Hi all,
>
> can I have reviews for this change that fixes a significant performance problem with g1 full gc marking when the overflow queue is in use? Basically this case causes the threads never share their work from the overflow queue, resulting in very bad parallelization in some cases.
>
> This is a problem that has been fixed already in [JDK-8152438](https://bugs.openjdk.java.net/browse/JDK-8152438), but when looking at this code on g1 and parallel full gc, they both showed that issue.
>
> This is the change for g1.
>
> The CR shows some numbers how bad this can be.
>
> Thanks,
> Thomas
Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
Comments, cleanup
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7175/files
- new: https://git.openjdk.java.net/jdk/pull/7175/files/8028a370..c447ea95
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7175&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7175&range=02-03
Stats: 5 lines in 1 file changed: 1 ins; 3 del; 1 mod
Patch: https://git.openjdk.java.net/jdk/pull/7175.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/7175/head:pull/7175
PR: https://git.openjdk.java.net/jdk/pull/7175
More information about the hotspot-gc-dev
mailing list