RFR: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Tue Jan 25 15:43:36 UTC 2022


On Mon, 17 Jan 2022 09:37:37 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - review
>>  - review
>
> src/hotspot/share/gc/shared/preservedMarks.hpp line 60:
> 
>> 58:   size_t size() const { return _stack.size(); }
>> 59:   inline void push_if_necessary(oop obj, markWord m);
>> 60:   inline void push_always(oop obj, markWord m);
> 
> Any reason not to just call this `push()` like we had in the past and maybe also re-use it in `push_if_necessary()`?

I was thinking `push_always` makes a clearer contrast with its neighbor: the two are parallel and there's no interconnection/dependency btw them.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7028



More information about the hotspot-gc-dev mailing list