RFR: 8280397: Factor out task queue statistics printing [v2]

Kim Barrett kbarrett at openjdk.java.net
Wed Jan 26 03:10:30 UTC 2022


On Mon, 24 Jan 2022 09:38:39 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that makes task queue (set) printing available in a central place so that not every user needs to reinvent the wheel?
>> As example I wired up existing G1/Parallel GC young collection statistics printing, but I intend to add this for full gcs too; since ZGC and Shenandoah do not print task queues at all I do not intend to do that at least initially.
>> Currently the main printing method is in `CollectedHeap`, but I can move it elsewhere if needed (all but Serial GC do use task queue sets though, so.....).
>> 
>> Testing: gha (building), local testing
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   pliden review

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp line 40:

> 38: #include "gc/g1/heapRegionRemSet.hpp"
> 39: #include "gc/g1/heapRegionSet.inline.hpp"
> 40: #include "gc/shared/collectedHeap.inline.hpp"

Not sure what this is for?  Maybe left-over from initial commit?

src/hotspot/share/gc/shared/collectedHeap.hpp line 30:

> 28: #include "gc/shared/gcCause.hpp"
> 29: #include "gc/shared/gcWhen.hpp"
> 30: #include "gc/shared/taskqueue.hpp"

Not sure what this is for.  Maybe left-over from initial commit?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7174



More information about the hotspot-gc-dev mailing list