RFR: 8280397: Factor out task queue statistics printing [v3]

Kim Barrett kbarrett at openjdk.java.net
Thu Jan 27 20:37:59 UTC 2022


On Wed, 26 Jan 2022 09:27:50 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that makes task queue (set) printing available in a central place so that not every user needs to reinvent the wheel?
>> As example I wired up existing G1/Parallel GC young collection statistics printing, but I intend to add this for full gcs too; since ZGC and Shenandoah do not print task queues at all I do not intend to do that at least initially.
>> Currently the main printing method is in `CollectedHeap`, but I can move it elsewhere if needed (all but Serial GC do use task queue sets though, so.....).
>> 
>> Testing: gha (building), local testing
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge branch 'master' into 8280397-central-taskqueue-printing
>  - kbarrett review, copyright dates
>  - pliden review
>  - Initial implementation using CollectedHeap

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7174



More information about the hotspot-gc-dev mailing list