RFR: 8287555: Tighten G1 G1BlockOffsetTable::block_start() code [v2]
Thomas Schatzl
tschatzl at openjdk.org
Wed Jul 6 12:48:29 UTC 2022
On Wed, 6 Jul 2022 12:43:53 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> can I have reviews for this change that specializes `G1BlockOffsetTablePart::block_size` with a variant used for card aligned addresses including some cleanup of comments? This saves some unnecessary lookup of the block size of the object found as for refinement the start address is always aligned.
>>
>> Testing: tier1, gha
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>
> - Cleanup
> - 828755:5 Tighten G1BlockOffsetTable::block_start() code
>
> initial version
> - Make block_start_reaching_into_card() const
> - initial version
After introduction of a separate change ( 8289538: Make G1BlockOffsetTablePart unaware of block sizes #9395 ) for some refactoring this change differs so much from the original so that it is more than reasonable to rebase this change on the other.
Only the last commit contains this change (c3866f3fc1ef5bade3ba4d723d87c4fb8bad5000) is part of this change.
-------------
PR: https://git.openjdk.org/jdk/pull/9059
More information about the hotspot-gc-dev
mailing list