RFR: 8289538: Make G1BlockOffsetTablePart unaware of block sizes [v4]

Thomas Schatzl tschatzl at openjdk.org
Thu Jul 7 16:26:07 UTC 2022


> Hi all,
> 
>   can I have reviews for this change that makes `G1BlockOffsetTablePart` unaware of block sizes: as discussed in PR#9059/[JDK-8287555](https://bugs.openjdk.org/browse/JDK-8287555) this is a good idea to make `G1BlockOffsetTablePart` just for "dumb" retrieval of the BOT entries, which makes the code simpler, avoiding some calling back and forth between `HeapRegion` and `G1BlockOffsetTablePart`.
> 
> There is still the wart that `G1BlockOffsetTablePart::verify()` needs `block_size`, but since it's just verification I think this is fine. An alternative suggested by @albertnetymk is to remove that method completely.
> 
> Testing: local compilation, gha, some benchmark checking that card scans/ms does not degrade
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:

 - Merge branch 'master' into 8289538-move-Ablock-size-out-of-bot
 - ayang review
 - cleanup
 - Make block_start_reaching_into_card() const
 - initial version

-------------

Changes: https://git.openjdk.org/jdk/pull/9395/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9395&range=03
  Stats: 156 lines in 6 files changed: 75 ins; 67 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/9395.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9395/head:pull/9395

PR: https://git.openjdk.org/jdk/pull/9395



More information about the hotspot-gc-dev mailing list