Integrated: 8289538: Make G1BlockOffsetTablePart unaware of block sizes

Thomas Schatzl tschatzl at openjdk.org
Thu Jul 7 18:12:07 UTC 2022


On Wed, 6 Jul 2022 11:56:47 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this change that makes `G1BlockOffsetTablePart` unaware of block sizes: as discussed in PR#9059/[JDK-8287555](https://bugs.openjdk.org/browse/JDK-8287555) this is a good idea to make `G1BlockOffsetTablePart` just for "dumb" retrieval of the BOT entries, which makes the code simpler, avoiding some calling back and forth between `HeapRegion` and `G1BlockOffsetTablePart`.
> 
> There is still the wart that `G1BlockOffsetTablePart::verify()` needs `block_size`, but since it's just verification I think this is fine. An alternative suggested by @albertnetymk is to remove that method completely.
> 
> Testing: local compilation, gha, some benchmark checking that card scans/ms does not degrade
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: f7b18305
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f7b183059a3023f8da73859f1577d08a807749b2
Stats:     145 lines in 6 files changed: 63 ins; 67 del; 15 mod

8289538: Make G1BlockOffsetTablePart unaware of block sizes

Reviewed-by: ayang, iwalulya

-------------

PR: https://git.openjdk.org/jdk/pull/9395



More information about the hotspot-gc-dev mailing list