RFR: 8289997: gc/g1/TestVerificationInConcurrentCycle.java fails due to use of debug-only option

[Kim Barrett]

On Fri, 8 Jul 2022 08:33:02 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this change that fixes failures in product VMs due to use of a debug-only verification option?
> 
> The change has the VM ignore that option as needed.
> 
> Thanks,
>   Thomas
> 
> Testing: local testing

Changes requested by kbarrett (Reviewer).

test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java line 39:

> 37:  *   -XX:+G1VerifyRSetsDuringFullGC -XX:+G1VerifyHeapRegionCodeRoots
> 38:  *   -XX:+VerifyRememberedSets -XX:+VerifyObjectStartArray
> 39:  *   -XX:+IgnoreUnrecognizedVMOptions -XX:+G1VerifyBitmaps

Rather than using `-XX:+IgnoreUnrecognizedVMOptions`, a "safer" solution would be to have two `@test` blocks, one that `@requires` a debug build and has that option, and one which `@requires` a product build and doesn't have the option.  (This would be less important if the IgnoreXXX option only affected options that follow it, but it's "special" and affects all the options, regardless of where it appears.)

-------------

PR: https://git.openjdk.org/jdk/pull/9424