RFR: 8290019: Refactor HeapRegion::oops_on_memregion_iterate()

Albert Mingkun Yang ayang at openjdk.org
Sun Jul 10 13:43:32 UTC 2022


On Fri, 8 Jul 2022 15:09:32 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this potential refactoring for `HeapRegion::oops_on_memregion_iterate()`; it's a bit subjective imo if the code is better now, so please feel free to say so and I'll retract.
> 
> Testing: tier1-3
> 
> Thanks,
>   Thomas

Marked as reviewed by ayang (Reviewer).

src/hotspot/share/gc/g1/heapRegion.inline.hpp line 407:

> 405: inline HeapWord* HeapRegion::oops_on_memregion_iterate_in_unparsable(MemRegion mr, HeapWord* block_start, Closure* cl) {
> 406:   HeapWord* const start = mr.start();
> 407:   // Only scan until parsable_bottom.

This comment can be dropped now.

-------------

PR: https://git.openjdk.org/jdk/pull/9430



More information about the hotspot-gc-dev mailing list