RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests

[Albert Mingkun Yang]

On Mon, 11 Jul 2022 07:39:02 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for removal of the use of `-XX:+IgnoreUnrecognizedVMOptions` for gc tests?
> 
> As per [JDK-8228493](https://bugs.openjdk.org/browse/JDK-8228493) use of that option has drawbacks wrt to test reliability, so trying to remove them by
> * duplicating `@test` blocks (mostly sme Shenandoah tests as I could not find a good way for them)
> * adding additional `@requires`
> * removing it in tests where it is not actually required
> 
> Testing: gha, running tests
> 
> Thanks,
>   Thomas

Marked as reviewed by ayang (Reviewer).

test/hotspot/jtreg/gc/metaspace/TestMetaspacePerfCounters.java line 153:

> 151:  *          java.management/sun.management
> 152:  *          jdk.internal.jvmstat/sun.jvmstat.monitor
> 153:  * @run main/othervm -XX:+UsePerfData -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC gc.metaspace.TestMetaspacePerfCounters

It's unclear to me why `-XX:+UnlockExperimentalVMOptions` is needed in this file.

test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java line 58:

> 56:  *          jdk.internal.jvmstat/sun.jvmstat.monitor
> 57:  * @run main/othervm -Xlog:class+load,class+unload=trace -XX:+UseSerialGC -XX:+UsePerfData -Xint gc.metaspace.TestPerfCountersAndMemoryPools
> 58:  * @run main/othervm -Xlog:class+load,class+unload=trace -XX:+UseSerialGC -XX:+UsePerfData -Xint gc.metaspace.TestPerfCountersAndMemoryPools

These two lines are identical; is this intended?

-------------

PR: https://git.openjdk.org/jdk/pull/9443