RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
Thomas Schatzl
tschatzl at openjdk.org
Tue Jul 12 08:07:45 UTC 2022
On Mon, 11 Jul 2022 17:52:08 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Hi all,
>>
>> can I have reviews for removal of the use of `-XX:+IgnoreUnrecognizedVMOptions` for gc tests?
>>
>> As per [JDK-8228493](https://bugs.openjdk.org/browse/JDK-8228493) use of that option has drawbacks wrt to test reliability, so trying to remove them by
>> * duplicating `@test` blocks (mostly sme Shenandoah tests as I could not find a good way for them)
>> * adding additional `@requires`
>> * removing it in tests where it is not actually required
>>
>> Testing: gha, running tests
>>
>> Thanks,
>> Thomas
>
> test/hotspot/jtreg/gc/g1/TestLargePageUseForAuxMemory.java line 121:
>
>> 119: "-XX:" + (largePageEnabled ? "+" : "-") + "UseLargePages" });
>> 120: if (Platform.is64bit()) {
>> 121: vmOpts.add("-XX:ObjectAlignmentInBytes=8");
>
> As 8 is the default value, I'm not sure why this option is being added.
Idk, I removed it.
-------------
PR: https://git.openjdk.org/jdk/pull/9443
More information about the hotspot-gc-dev
mailing list