RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v2]

Leo Korinth lkorinth at openjdk.org
Tue Jul 12 10:42:43 UTC 2022


On Tue, 12 Jul 2022 08:36:59 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for removal of the use of `-XX:+IgnoreUnrecognizedVMOptions` for gc tests?
>> 
>> As per [JDK-8228493](https://bugs.openjdk.org/browse/JDK-8228493) use of that option has drawbacks wrt to test reliability, so trying to remove them by
>> * duplicating `@test` blocks (mostly sme Shenandoah tests as I could not find a good way for them)
>> * adding additional `@requires`
>> * removing it in tests where it is not actually required
>> 
>> Testing: gha, running tests
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ayang, kbarrett review

Looks good.

-------------

Marked as reviewed by lkorinth (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9443



More information about the hotspot-gc-dev mailing list