RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v4]

Thomas Schatzl tschatzl at openjdk.org
Wed Jul 13 09:38:38 UTC 2022


> Hi all,
> 
>   can I have reviews for removal of the use of `-XX:+IgnoreUnrecognizedVMOptions` for gc tests?
> 
> As per [JDK-8228493](https://bugs.openjdk.org/browse/JDK-8228493) use of that option has drawbacks wrt to test reliability, so trying to remove them by
> * duplicating `@test` blocks (mostly sme Shenandoah tests as I could not find a good way for them)
> * adding additional `@requires`
> * removing it in tests where it is not actually required
> 
> Testing: gha, running tests
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:

  Fix x86 metaspaceperfcounters test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9443/files
  - new: https://git.openjdk.org/jdk/pull/9443/files/1b530193..4c5d78f6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9443&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9443&range=02-03

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/9443.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9443/head:pull/9443

PR: https://git.openjdk.org/jdk/pull/9443



More information about the hotspot-gc-dev mailing list