RFR: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests [v5]
Kim Barrett
kbarrett at openjdk.org
Wed Jul 13 14:03:11 UTC 2022
On Wed, 13 Jul 2022 13:51:15 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> can I have reviews for removal of the use of `-XX:+IgnoreUnrecognizedVMOptions` for gc tests?
>>
>> As per [JDK-8228493](https://bugs.openjdk.org/browse/JDK-8228493) use of that option has drawbacks wrt to test reliability, so trying to remove them by
>> * duplicating `@test` blocks (mostly sme Shenandoah tests as I could not find a good way for them)
>> * adding additional `@requires`
>> * removing it in tests where it is not actually required
>>
>> Testing: gha, running tests
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> Epsilon needs UnlockExperimentalOptions
Drat! I meant to check for that and then forgot. Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9443
More information about the hotspot-gc-dev
mailing list