RFR: 8290512: G1: Fix typo in allocation statistics log message
Kim Barrett
kbarrett at openjdk.org
Tue Jul 19 11:18:04 UTC 2022
On Tue, 19 Jul 2022 09:08:19 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this trivial change to add a whitespace to a log message.
>
> Testing: local compilation
>
> Thanks,
> Thomas
Looks good, and trivial, but with a suggestion for further improvement if you want.
src/hotspot/share/gc/g1/g1OldGenAllocationTracker.cpp line 53:
> 51:
> 52: log_debug(gc, alloc, stats)("Old generation allocation in the last mutator period, "
> 53: "old gen allocated: " SIZE_FORMAT "B, humongous allocated: " SIZE_FORMAT "B, "
You could replace uses of `SIZE_FORMAT` with "%zu" formatting directives, which might allow removal of the line break in the string without making it overly long.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9552
More information about the hotspot-gc-dev
mailing list