RFR: 8237913: G1CollectedHeap::heap_region_containing shouldn't be a template [v2]

Sangheon Kim sangheki at openjdk.org
Wed Jul 27 19:25:38 UTC 2022


On Thu, 21 Jul 2022 08:00:01 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that removes the templates and casts around `G1CollectedHeap::heap_region_containing`?
>> 
>> Testing: tier1-5
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   kbarrett review

src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp line 108:

> 106: }
> 107: 
> 108: inline HeapRegion* G1CollectedHeap::heap_region_containing_or_null(HeapWord* addr) const {

Why 2 asserts are removed?
Because the only caller has already checked such things?

-------------

PR: https://git.openjdk.org/jdk/pull/9572



More information about the hotspot-gc-dev mailing list