Integrated: 8290715: Fix incorrect uses of G1CollectedHeap::heap_region_containing()

Thomas Schatzl tschatzl at openjdk.org
Fri Jul 29 15:48:43 UTC 2022


On Thu, 21 Jul 2022 08:06:04 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   please review this change that fixes some callers of `G1CollectedHeap::heap_region_containing` to a) fail on trying to get the `Heapregion*` on uncommitted regions and b) change some callers to use the correct `heap_region_containing_or_null` method that had been intended there.
> 
> Also remove some now unneccessary asserts as `heap_region_containing` will fail when it previously returned `nullptr`.
> 
> Testing: tier1-5
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: f58e08e2
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f58e08e2585186e1b3ca2cad20b342d83a8ab133
Stats:     23 lines in 5 files changed: 1 ins; 8 del; 14 mod

8290715: Fix incorrect uses of G1CollectedHeap::heap_region_containing()

Reviewed-by: kbarrett, sangheki

-------------

PR: https://git.openjdk.org/jdk/pull/9584



More information about the hotspot-gc-dev mailing list