RFR: 8278598: AlignmentReserve is repeatedly reinitialized
Ivan Walulya
iwalulya at openjdk.java.net
Wed Jun 1 15:30:26 UTC 2022
On Fri, 20 May 2022 12:54:33 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that makes initialization of `AlignmentReserve` a one-time thing; after looking at the suggested change and the code I opted to use a static in `CollectedHeap` that can be queried by its users (`PLAB` and `ThreadLocalAllocBuffer`). This seemed nicer to me.
>
> Testing: gha, running gcbasher with all collectors (notice that there is an assert in the getter that checks for initialization before retrieval, so this should be sufficient)
>
> Thanks,
> Thomas
Lgtm!
-------------
Marked as reviewed by iwalulya (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8808
More information about the hotspot-gc-dev
mailing list