RFR: 8287771: Remove useless G1 After GC summary refinement and sampling thread times [v2]

tqxia duke at openjdk.java.net
Wed Jun 15 15:06:56 UTC 2022


On Wed, 15 Jun 2022 02:58:15 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> An alternative to the new bool argument to print_on would be to add a new function print_vtimes_on, and call it in the appropriate places before calling print_on. Just tossing the idea out there.

Thanks for the suggestion. After playing with the code a little bit more, I guess I will stick with the new flag for now for 2 reasons:
1. There is some shared calculation before printing thread times and printing other rem set information.
2. Since print_on(or print_thread_times_on) will be a method on G1RemSetSummary, in order to invoke it in G1HeapPrinterMark(where the decision is made), we probably need to create another wrapper for it on G1RemSet.

-------------

PR: https://git.openjdk.org/jdk/pull/9106



More information about the hotspot-gc-dev mailing list