RFR: 8287805: Shenandoah: consolidate evacuate-update-root closures [v3]

Zhengyu Gu zgu at openjdk.org
Thu Jun 23 18:08:00 UTC 2022


On Thu, 23 Jun 2022 17:52:14 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahClosures.hpp line 99:
>> 
>>> 97:     inline ShenandoahEvacuateUpdateRootClosureBase();
>>> 98:     inline virtual void do_oop(oop* p);
>>> 99:     inline virtual void do_oop(narrowOop* p);
>> 
>> Do we have to make these functions `virtual`? I supposed we do templated closures exactly to avoid any sort of virtual method dispatching. Maybe I am missing something here...
>
> Fixed

Removed `virtual` keyword

-------------

PR: https://git.openjdk.org/jdk/pull/9023



More information about the hotspot-gc-dev mailing list