RFR: 8287805: Shenandoah: consolidate evacuate-update-root closures [v3]

Aleksey Shipilev shade at openjdk.org
Fri Jun 24 17:47:55 UTC 2022


On Thu, 23 Jun 2022 18:07:58 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> ShenandoahEvacuateUpdateMetadataClosure and ShenandoahEvacuateUpdateRootsClosure are mostly same, can be consolidated.
>> 
>> Also, only uses of ShenandoahEvacuateUpdateMetadataClosure all pass MO_UNORDERED template parameter, so it can be eliminated.
>> 
>> Test:
>> 
>> - [x] hotspot_gc_shenandoah
>
> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused impl

I still dislike the fact we are calling `Thread::current()` on hotpath. I think we can do better. Consider this modification on top of your current PR: http://cr.openjdk.java.net/~shade/8287805/thread-1.patch -- does that look better?

-------------

PR: https://git.openjdk.org/jdk/pull/9023



More information about the hotspot-gc-dev mailing list