[jdk19] RFR: 8289093: BlockLocationPrinter fails to decode addresses with G1 [v2]

Albert Mingkun Yang ayang at openjdk.org
Mon Jun 27 08:51:35 UTC 2022


On Mon, 27 Jun 2022 08:31:01 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that fixes an assertion failure when trying to add annotations to the hs_err file?
>> 
>> The `block_start` API from `CollectedHeap` assumes that useful values for all given addresses is returned, not asserting/crashing like some method deeper in the call chain does since [JDK-8270540](https://bugs.openjdk.org/browse/JDK-8270540), resulting in somewhat scrambled hs_err files and additional stack frames to look at in the debugger. 
>> 
>> Testing: local compilation, gha, tier1-3
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix return value to just return null

Marked as reviewed by ayang (Reviewer).

-------------

PR: https://git.openjdk.org/jdk19/pull/68



More information about the hotspot-gc-dev mailing list