[jdk19] Integrated: 8289093: BlockLocationPrinter fails to decode addresses with G1
Thomas Schatzl
tschatzl at openjdk.org
Mon Jun 27 11:45:41 UTC 2022
On Fri, 24 Jun 2022 12:04:49 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that fixes an assertion failure when trying to add annotations to the hs_err file?
>
> The `block_start` API from `CollectedHeap` assumes that useful values for all given addresses is returned, not asserting/crashing like some method deeper in the call chain does since [JDK-8270540](https://bugs.openjdk.org/browse/JDK-8270540), resulting in somewhat scrambled hs_err files and additional stack frames to look at in the debugger.
>
> Testing: local compilation, gha, tier1-3
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: 699ad45b
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.org/jdk19/commit/699ad45b4339940980314d4cd6e4606a66183fda
Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
8289093: BlockLocationPrinter fails to decode addresses with G1
Reviewed-by: ayang, iwalulya
-------------
PR: https://git.openjdk.org/jdk19/pull/68
More information about the hotspot-gc-dev
mailing list