RFR: 8282621: G1: G1SegmentedArray remove unnecessary template parameter [v3]

[Kim Barrett]

On Fri, 4 Mar 2022 21:24:37 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this refactoring change to remove unnecessary template parameters. The change has two commits, one to remove the template parameter, this allows for the second clean up to hoist `G1CardSetAllocator` parameter independent methods and variables into a base class.
>> 
>> Testing: Tier 1.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove G1CardSetContainer type info from the allocator

Changes requested by kbarrett (Reviewer).

src/hotspot/share/gc/g1/g1CardSetMemory.hpp line 110:

> 108:   inline size_t wasted_mem_size() const;
> 109: 
> 110:   inline uint num_segments() const;

Do `mem_size` and `wasted_size` need to be inline?  They don't seem like they should be performance critical.  I'm not sure about `num_segments` because I haven't checked uses.

src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp line 158:

> 156: template <MEMFLAGS flag>
> 157: G1SegmentedArray<flag>::G1SegmentedArray(const G1SegmentedArrayAllocOptions* alloc_options,
> 158:                                                G1SegmentedArrayFreeList<flag>* free_segment_list) :

Fix parameter indentation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7689