RFR: 8282621: G1: G1SegmentedArray remove unnecessary template parameter [v4]

[Kim Barrett]

On Sat, 5 Mar 2022 07:25:46 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>> Please review this refactoring change to remove unnecessary template parameters. The change has two commits, one to remove the template parameter, this allows for the second clean up to hoist `G1CardSetAllocator` parameter independent methods and variables into a base class.
>> 
>> Testing: Tier 1.
>
> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   kim review: cleanup

Looks good.  Just a minor comment cleanup.

src/hotspot/share/gc/g1/g1CardSetMemory.hpp line 68:

> 66: //
> 67: // Allocation occurs from an internal free list of objects first, if the free list is
> 68: // empty then tries to bump-allocate from the G1SegmentedArray.

I think this would read a bit better if the comma after "first" was changed to a period.  Also suggest changing "bump-allocate" to just "allocate".  Details of how G1SegmentedArray handles allocation should be described there.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/7689