RFR: 8282763: G1: G1CardSetContainer remove intrusive-list details. [v3]

Kim Barrett kbarrett at openjdk.java.net
Thu Mar 10 17:22:45 UTC 2022


On Thu, 10 Mar 2022 16:20:47 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix includes
>
> src/hotspot/share/gc/g1/g1CardSetContainers.hpp line 146:
> 
>> 144:   uintptr_t _ref_count;
>> 145: protected:
>> 146:   ~G1CardSetContainer() = default;
> 
> I think the destructor can be omitted completely.

Omitting this destructor declaration would make the destructor implicitly public, which would make accidental slicing possible.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7743



More information about the hotspot-gc-dev mailing list