RFR: 8256265: G1: Improve parallelism in regions that failed evacuation [v11]

Hamlin Li mli at openjdk.java.net
Fri Mar 11 12:33:42 UTC 2022


On Mon, 7 Mar 2022 10:13:00 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move 'chunks per region' log
>
> src/hotspot/share/gc/g1/g1EvacFailureRegions.hpp line 76:
> 
>> 74:   uint max_regions() const {
>> 75:     return _max_regions;
>> 76:   }
> 
> Looking at how this field is used:
> 
> 1. `region_idx < _max_regions`; can be caught the underlying bitmap
> 2.  `_max_regions = 0; // To have any record() attempt fail...`; can be replaced by a null-check of `_evac_failure_regions`.
> 
> This issue is preexisting though.

Thanks for the detailed review, sorry for the delayed response.

Nice catch! And I think the second one can also be caught by the underlying bitmap.
I will update the patch later.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7047



More information about the hotspot-gc-dev mailing list