RFR: 8283188: Build time regression caused by JDK-8278917
Kim Barrett
kbarrett at openjdk.java.net
Wed Mar 16 16:13:40 UTC 2022
On Wed, 16 Mar 2022 12:29:05 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Move `G1CollectedHeap::mark_evac_failure_object` to cpp so that `g1CollectedHeap.inline.hpp` doesn't need to include `g1ConcurrentMark.inline.hpp`.
>
> With the patch, the build time of clean fastdebug is reduced by ~16s.
>
> Before: 6:25.72
> After: 6:09.76
Looks good.
I was curious, so a dug into the data a bit. According to the build system's generated .d files, this removes 61 files from transitive closure of the includes for g1CollectedHeap.inline.hpp, some of them fairly large. And g1CollectedHeap.inline.hpp is itself included 59 times.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7839
More information about the hotspot-gc-dev
mailing list