RFR: 8283566: G1: Improve G1BarrierSet::enqueue performance [v2]

Aleksey Shipilev shade at openjdk.java.net
Wed Mar 30 10:11:39 UTC 2022


On Wed, 30 Mar 2022 08:55:34 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - enqueue_loc
>>  - Merge branch 'master' into JDK-8283566-g1-enqueue
>>  - Cleanups
>>  - More complete patch
>>  - Inlining
>
> src/hotspot/share/gc/g1/g1BarrierSet.hpp line 61:
> 
>> 59:   // pre-marking object graph. Prefer the version that takes location, as it
>> 60:   // can avoid touching the heap unnecessarily.
>> 61:   template <class T> static void enqueue_loc(T* dst);
> 
> Since the "location" version should be preferred, I would have used
> 
> 
> templace <class T>
> static void enqueue(T* dst);
> 
> static void enqueue_preloaded(oop pre_val);
> 
> to make the preferred version "default". Just my 2c.

`enqueue_preloaded` it is! See new commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7921



More information about the hotspot-gc-dev mailing list