RFR: 8285710: miscalculation of G1CardSetAllocator wasted memory size [v3]
tqxia
duke at openjdk.java.net
Sat May 7 02:33:53 UTC 2022
On Sat, 7 May 2022 02:22:05 GMT, tqxia <duke at openjdk.java.net> wrote:
>> when calculating the wasted memory size of G1CardSetAllocator, the code erroneously substracted both _segmented_array.num_allocated_slots() and _free_slots_list.pending_count() from _segmented_array.num_available_slots().
>>
>> The correct formula should be: num_wasted_slots = _segmented_array.num_available_slots() - (_segmented_array.num_allocated_slots() - (uint)_free_slots_list.pending_count()).
>>
>> This can potentially leads to an arithmetic overflow and misleading information will be displayed when G1SummarizeRSetStatsPeriod is set.
>
> tqxia has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
> 8285710: miscalculation of G1CardSetAllocator unused memory size
Code is updated according to comments above. Branch is sync with master. Please review again.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8424
More information about the hotspot-gc-dev
mailing list