RFR: 8285710: Miscalculation of G1CardSetAllocator unused memory size [v5]

[Thomas Schatzl]

On Sat, 7 May 2022 12:03:46 GMT, tqxia <duke at openjdk.java.net> wrote:

>> when calculating the wasted memory size of G1CardSetAllocator, the code erroneously substracted both _segmented_array.num_allocated_slots() and _free_slots_list.pending_count() from _segmented_array.num_available_slots().
>> 
>> The correct formula should be: num_wasted_slots = _segmented_array.num_available_slots() - (_segmented_array.num_allocated_slots() - (uint)_free_slots_list.pending_count()).
>> 
>> This can potentially leads to an arithmetic overflow and misleading information will be displayed when G1SummarizeRSetStatsPeriod is set.
>
> tqxia has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8285710: Miscalculation of G1CardSetAllocator unused memory size

Lgtm.

Note that in the gc team (for gc specific issues) we typically expect two people with appropriate roles (one of them being a "R"eviewer) to have reviewed a change before pushing. That improves spread of information.

Either way, this change is good, I'll sponsor.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8424