RFR: 8286628: Remove unused BufferNode::Allocator::flush_free_list

Kim Barrett kbarrett at openjdk.java.net
Fri May 13 02:21:49 UTC 2022


On Thu, 12 May 2022 09:08:26 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple change of removing an unused API.
> 
> Test: hotspot_gc

I was a bit surprised it isn't used more, but couldn't come up with any
missing uses.

The change violates the Law of Demeter, but that's pretty much par for HotSpot
code. (I think it's a useful design rule and yet often fail to follow it
myself.) Just support of whitebox testing isn't a great rationale for a public
API function if it can be done without.

So looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8676



More information about the hotspot-gc-dev mailing list