RFR: 8286943: G1: With virtualized remembered sets, maximum number of cards configured is wrong
Thomas Schatzl
tschatzl at openjdk.java.net
Wed May 18 17:20:20 UTC 2022
Hi all,
can I get reviews for this change that fixes passing a wrong parameter value to card set configuration that
* prevents upgrading a Howl container to Full with virtualized remembered sets (Heap regions >= 64M) as the (default) threshold for coarsening from Howl to Full is max_cards_in_cardset * 0.9, which is always higher than the value tested against (65k, max card set container element number).
* and also unnecessarily increases the bits used for inline ptrs
I added some basic parameter verification to the main constructor which would have caught this issue.
Testing: gha, tier1-3
Thanks,
Thomas
-------------
Commit messages:
- More checks
- Initial changes, add more consistency checks
Changes: https://git.openjdk.java.net/jdk/pull/8773/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8773&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8286943
Stats: 35 lines in 4 files changed: 28 ins; 0 del; 7 mod
Patch: https://git.openjdk.java.net/jdk/pull/8773.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/8773/head:pull/8773
PR: https://git.openjdk.java.net/jdk/pull/8773
More information about the hotspot-gc-dev
mailing list