RFR: 8286893: G1: Recent card set coarsening statistics wrong [v3]

tqxia duke at openjdk.java.net
Thu May 19 13:56:56 UTC 2022


On Thu, 19 May 2022 12:53:06 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> tqxia has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available.
>
> src/hotspot/share/gc/g1/g1CardSet.hpp line 164:
> 
>> 162:   void reset();
>> 163: 
>> 164:   void set_from(G1CardSetCoarsenStats& other);
> 
> Suggestion:
> 
>   void set(G1CardSetCoarsenStats& other);
> 
> Just `set()` is fine here; the reason why the other operation is called `subtract_from()` is that it subtracts the current value from the parameter, not the other way around.

Got it, updated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8785



More information about the hotspot-gc-dev mailing list