RFR: 8287024: G1: Improve the API boundary between HeapRegionRemSet and G1CardSet [v2]

Ivan Walulya iwalulya at openjdk.java.net
Fri May 20 08:12:41 UTC 2022


On Thu, 19 May 2022 15:38:31 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I get reviews for this small refactoring that clarifies the boundaries of what kind of data `HeapRegionRemSet` and `G1CardSet` should operate on?
>> 
>> * `HeapRegionRemSet` deals with addresses, heap regions
>> * `G1CardSet` deals with card indexes in the heap, card regions and cards within card regions
>> 
>> The `G1CardSet::add_card()` and `G1CardSet::contains_card()` methods are fuzzy about that, they require the caller (`HeapRegionRemSet`) to know about card regions and cards within regions. 
>> 
>> Testing: gha
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ayang review

Marked as reviewed by iwalulya (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8790



More information about the hotspot-gc-dev mailing list