RFR: 8189669: Deduplicate VerifyOption documentation
Kim Barrett
kbarrett at openjdk.java.net
Sat May 21 04:05:39 UTC 2022
On Fri, 20 May 2022 13:10:27 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have quick reviews for this trivial? change that deduplicates some documentation?
>
> Testing: local compilation
>
> Thanks,
> Thomas
Looks good, and trivial.
src/hotspot/share/gc/shared/verifyOption.hpp line 37:
> 35: // Use "next" mark bitmap information from full gc marking. This does not
> 36: // use (or need) TAMS.
> 37: VerifyOption_G1UseFullMarking = VerifyOption_G1UsePrevMarking + 1
I suggest that as a followup this should be an enum class, with the `VerifyOption_` prefix dropped from the enumerators, instead using `VerifyOption::G1UsePrevMarking` (for example).
-------------
Marked as reviewed by kbarrett (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8809
More information about the hotspot-gc-dev
mailing list