Integrated: 8287024: G1: Improve the API boundary between HeapRegionRemSet and G1CardSet

Thomas Schatzl tschatzl at openjdk.java.net
Mon May 23 08:35:01 UTC 2022


On Thu, 19 May 2022 14:53:59 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I get reviews for this small refactoring that clarifies the boundaries of what kind of data `HeapRegionRemSet` and `G1CardSet` should operate on?
> 
> * `HeapRegionRemSet` deals with addresses, heap regions
> * `G1CardSet` deals with card indexes in the heap, card regions and cards within card regions
> 
> The `G1CardSet::add_card()` and `G1CardSet::contains_card()` methods are fuzzy about that, they require the caller (`HeapRegionRemSet`) to know about card regions and cards within regions. 
> 
> Testing: gha
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: cb08b4e8
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/cb08b4e86a8b79b886beebe482be6d842d79c517
Stats:     146 lines in 5 files changed: 81 ins; 53 del; 12 mod

8287024: G1: Improve the API boundary between HeapRegionRemSet and G1CardSet

Reviewed-by: ayang, iwalulya

-------------

PR: https://git.openjdk.java.net/jdk/pull/8790



More information about the hotspot-gc-dev mailing list