RFR: 8286304: Removal of diagnostic flag GCParallelVerificationEnabled [v3]

[Kim Barrett]

On Tue, 24 May 2022 09:06:22 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I get your opinion about this change, if you think it's worth doing, and if so, a review for it?
>> 
>> If the change goes forward, I will do a release note. Since this is a diagnostic flag, there is no CSR required.
>> 
>> I grepped sources for that flag, it seems to be only used in these two places.
>> 
>> Testing: local compilation
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge branch 'master' into pull/8812-gcparallelverification
>  - Removal
>  - 8286304: Rename diagnostic flag GCParallelVerificationEnabled to UseGCParallelVerification

Looks good, other than perhaps a small change to error reporting.  I don't need a re-review for that.

src/hotspot/share/gc/g1/g1HeapVerifier.cpp line 501:

> 499:     _g1h->print_extended_on(&ls);
> 500: 
> 501:     guarantee(false, "there should not have been any failures");

Seems like clearer would be `fatal(...)` rather than `guarantee(false, ...)`?

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8813