RFR: 8296130: G1: Remove G1YoungCollector::_target_pause_time_ms
Kim Barrett
kbarrett at openjdk.org
Wed Nov 2 06:33:30 UTC 2022
On Mon, 31 Oct 2022 14:27:05 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Simple change of narrowing down the scope of target-pause-time.
>
> Test: hotspot_gc
Looks good. Just a couple potential formatting suggestions.
src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2027:
> 2025: LOG_COLLECT_CONCURRENTLY(cause, "attempt %u", i);
> 2026: VM_G1TryInitiateConcMark op(gc_counter,
> 2027: cause);
Consider removing the line break here.
src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 2652:
> 2650: VM_G1CollectForAllocation op(word_size,
> 2651: gc_count_before,
> 2652: gc_cause);
Consider removing the line breaks here.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10919
More information about the hotspot-gc-dev
mailing list